Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add special handling for names we might get wrong (#25570) #25604

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

jahzielv
Copy link
Contributor

cherry-pick for #25570

> For #25467

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)
- [x] If database migrations are included, checked table schema to
confirm autoupdate
- For database migrations:
- [x] Checked schema for all modified table for columns that will
auto-update timestamps during migration.
- [x] Confirmed that updating the timestamps is acceptable, and will not
cause unwanted side effects.
- [x] Ensured the correct collation is explicitly set for character
columns (`COLLATE utf8mb4_unicode_ci`).
- [x] Added/updated automated tests
- [x] A detailed QA plan exists on the associated ticket (if it isn't
there, work with the product group's QA engineer to add it)
- [x] Manual QA for all new/changed functionality
@jahzielv jahzielv requested a review from a team as a code owner January 20, 2025 16:49
@jahzielv jahzielv merged commit 8e3a5d8 into rc-minor-fleet-v4.63.0 Jan 20, 2025
23 checks passed
@jahzielv jahzielv deleted the 25467-cherry-pick branch January 20, 2025 17:04
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (rc-minor-fleet-v4.63.0@1817eda). Learn more about missing BASE report.

Additional details and impacted files
@@                    Coverage Diff                    @@
##             rc-minor-fleet-v4.63.0   #25604   +/-   ##
=========================================================
  Coverage                          ?   63.58%           
=========================================================
  Files                             ?     1619           
  Lines                             ?   154933           
  Branches                          ?     4038           
=========================================================
  Hits                              ?    98520           
  Misses                            ?    48644           
  Partials                          ?     7769           
Flag Coverage Δ
backend 64.43% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants